Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in drupalRoot and composerRoot detection if the installer paths of package drupal/core is dynamically set and not in composer.json #39

Open
mikaelmeulle opened this issue Oct 9, 2018 · 1 comment

Comments

@mikaelmeulle
Copy link

mikaelmeulle commented Oct 9, 2018

DrupalFinder is unable to detect drupalRoot and composerRoot in the following cases :

  • a project has a composer.json at its root path but installs drupal core (package drupal/core) in a subdirectory
  • the rule to place the package drupal/core is not written into the composer.json, but it is set inside a composer plug-in which patches the "extra" section when composer runs.

I saw in the source code of Drupalfinder, composer.json files may be opended and parsed to search for the target installation path of the drupal/core package. One way to improve this, if possible, may be to change the code of DrupalFinder to use the composer object and retrieve the content of the extra section directly in PHP...
what do you think?

@JPustkuchen
Copy link

Same problem here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants