-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite project into TypeScript #570
Comments
I would like to work on this. |
Awesome, thanks for stepping in. I would suggest to tackle this in small pieces, e.g. rather raising many small PRs than one huge one. |
Okay should i start with installing typescript in the project and then write the files in typescript one by one ? |
@VedanthB sounds like a good approach, maybe have a first PR that provides the TS setup and already have the package point to the compiled JS files. Then a PR for every file. |
I'll submit the PR in a day 😄 |
Can i get help to get this running on my local machine ? |
Sure, where do you struggle with? Did you check out the Contributing guidelines. It isn't much but it helped me to get it setup locally. |
i have cloned the project and |
You should be able to run all tests via |
We made the experience that switching to TypeScript had a good impact on the code quality and development velocity. We should also rewrite this project into TypeScript to leverage from the same.
The text was updated successfully, but these errors were encountered: