Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minimal required Electron version needed to use the service without manually configuring Chromedriver #705

Closed
christian-bromann opened this issue Jul 27, 2024 · 1 comment · Fixed by #729
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@christian-bromann
Copy link
Contributor

As a user trying to set up tests on my project that is using Electron v18 I am getting confused when I get the following error message:

Failed downloading chromedriver v100: Download failed: server returned code 404. URL:

Can we:

  1. document in the readme what the minimum required version needs to be?
  2. can we maybe add a check in the code to provide a better error message?
@goosewobbler goosewobbler added this to the 7.0.0 milestone Jul 30, 2024
@goosewobbler goosewobbler added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 30, 2024
@goosewobbler
Copy link
Member

We've got this in the Chromedriver configuration:
https://github.com/webdriverio-community/wdio-electron-service/blob/main/docs/configuration/chromedriver-configuration.md#user-managed

I think we can mention the minimum required Electron version to avoid having to self-configure chromedriver on the main README, and also update the error message.

@goosewobbler goosewobbler changed the title Document minimal required Electron version needed to use the service Document minimal required Electron version needed to use the service without manually configuring Chromedriver Jul 30, 2024
@goosewobbler goosewobbler linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants