Fix #767: display proper URL hostname when scheme is missing slashes #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlcow
changed the title
daliacoss
changed the title
| from webcompat import form | ||
|
|
||
|
|
||
| class TestForm(unittest.TestCase): |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
This is a good start @deckycoss, let me or @karlcow know if you have any other questions. |
|
@miketaylr i believe this last commit should address your feedback |
|
LGTM. 👍 |
miketaylr
pushed a commit
that referenced
this pull request
Mar 9, 2016
Fix #767: display proper URL hostname when scheme is missing slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this updates webcompat.form.normalize_url to account for missing slashes (e.g., "http:/example.com"), and adds basic unit tests for normalize_url and domain_name.
r? @miketaylr