Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual style regressions for QR code stuff #930

Closed
miketaylr opened this issue Mar 1, 2016 · 5 comments
Closed

Visual style regressions for QR code stuff #930

miketaylr opened this issue Mar 1, 2016 · 5 comments

Comments

@miketaylr
Copy link
Member

STR:

Go to any issue page, click on QR code.

The qr icon itself should should be in the little gray bar, and should be bigger when clicked.

@dshgna
Copy link
Contributor

dshgna commented Mar 3, 2016

Hi @miketaylr

Could you clarify whether the following meets the requirement, please?

alt text

@magsout
Copy link
Member

magsout commented Mar 3, 2016

@dshgna I think that's what @miketaylr meant . IMO, I find the position much better

@dshgna
Copy link
Contributor

dshgna commented Mar 3, 2016

@magsout Thanks for the feedback! I'll commit and make the pull request then.

@magsout
Copy link
Member

magsout commented Mar 3, 2016

@dshgna 👍

dshgna pushed a commit to dshgna/webcompat.com that referenced this issue Mar 3, 2016
@miketaylr
Copy link
Member Author

Yes, thanks! 🎈

dshgna pushed a commit to dshgna/webcompat.com that referenced this issue Mar 3, 2016
miketaylr pushed a commit that referenced this issue Mar 4, 2016
Issue #930 - Fix QR code style issues
miketaylr pushed a commit that referenced this issue Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants