Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #819. Update ua-parser to 0.5.0. #820

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Fixes #819. Update ua-parser to 0.5.0. #820

merged 1 commit into from
Nov 5, 2015

Conversation

miketaylr
Copy link
Member

This will fix the broken detection of Firefox tablets as Android browser. However, they will be identified as Firefox Mobile.

r? @karlcow

@karlcow
Copy link
Member

karlcow commented Nov 5, 2015

With 💖. Thanks.

karlcow added a commit that referenced this pull request Nov 5, 2015
Fixes #819. Update ua-parser to 0.5.0.
@karlcow karlcow merged commit 9f608b0 into master Nov 5, 2015
@miketaylr
Copy link
Member Author

For the history books, this updated fine locally -- but totally broke production for about 10 minutes. 💣

I assume version 0.51 will fix this: ua-parser/uap-python#34

I don't have the error in front of me (I didn't think to copy it down), but installation was failing because it was looking for the regexes.yaml inside a uap-core directory that wasn't there (it was inside ua_parser, iirc).

These are the commands I used to fix it, from bash history:

1992  git clone [email protected]:ua-parser/uap-core.git
 1993  ls
 1994  mv uap-core/ webcompat.com/build/ua-parser/
 1995  sudo mv uap-core/ webcompat.com/build/ua-parser/
 1996  ls
 1997  cd webcompat.com/
 1998  sl
 1999  ls
 2000  sudo pip install ua-parser

@miketaylr
Copy link
Member Author

(lol @ sl)

@miketaylr miketaylr deleted the issues/819/1 branch March 5, 2016 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants