-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dropdown to user to Header #738
Conversation
Ah hum and yes, I need to rewrite some test about logout user. |
🎈 |
Just pushed my last commit for these beautiful and awesome days. |
aaaaw ❤️ Thanks a lot for the amazing work. |
🎉 |
I'm happy to re-write the logout test stuff, no worries. |
Ah, actually I changed the test yesterday that instead of clicking on a link, it just navigates directly to the |
{% if session.user_id and session.avatar_url %} | ||
<img class="wc-Navbar-avatar" src="{{ session.avatar_url }}s=40" alt="User Avatar"> | ||
{% endif %} |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
And I guess we can make this change for nav.html as well. |
ah yes, it's a different view. I forgot it. There is a way to mixe this two views ? |
I was just wondering about that. Looking at them both, we can pull out the "All issues" "login" "logout" links into its own partial and at least share that code. |
I just pulled out the common stuff and made a |
…icking outside.
fed6a1b
to
d27efba
Compare
@magsout I rebased against master (and force pushed) just now because I need to fix the login test, so please do a edit: I guess I didn't need to, but wanted to. 😎 |
@magsout just a thought, we could land this on master now if we commented out the "My Activity" link. Then we could work on the me-dashboard in a new branch. WDYT? |
yeah, looks good to me. |
Cool, I'll comment that out and then merge this. |
r+ for @magsout work. I'll ask for review on the JS additions when we land the dashboard (or something). |
Added Dropdown to user to Header
ahahahah |
Call me : Mr GIF |
Need to populate link inside dropdown
When button is clicked, just added as usual
is-active
towc-DropdownHeader
and for accessibility change value of
aria-pressed
r? @miketaylr