Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3528 - Fix CSS for description textarea #3535

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Feb 10, 2021

Make the progress bar not overlap the textarea. While at it, also remove useless content: "" rules which do nothing, and an useless width declaration which also does nothing because it's the same width as the block would have minus margins.

This PR fixes issue #3528

Proposed PR background

See #3528

Make the progress bar not overlap the textarea. While at it, also remove useless `content: ""` rules which do nothing, and an useless `width` declaration which also does nothing because it's the same width as the block would have minus margins.
@emilio
Copy link
Contributor Author

emilio commented Feb 10, 2021

cc @karlcow

@karlcow
Copy link
Member

karlcow commented Feb 10, 2021

This change the initial design (not that I'm fond of it).

#3534 design

Capture d’écran 2021-02-10 à 12 19 53

#3535 design

Capture d’écran 2021-02-10 à 12 20 02

Though yes the full thing could be redone a bit better.

@karlcow karlcow changed the title Fix #3528 Fix #3528 - Fix CSS for description textarea Feb 10, 2021
@karlcow
Copy link
Member

karlcow commented Feb 10, 2021

ok indeed in my design long lines are not working.

@karlcow
Copy link
Member

karlcow commented Feb 10, 2021

This will fix it. Let's merge it and we might need to open an issue to solve this design later on.
At least it's usable now.

Thanks @emilio

@karlcow karlcow self-requested a review February 10, 2021 03:44
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@karlcow karlcow linked an issue Feb 10, 2021 that may be closed by this pull request
@karlcow karlcow merged commit 37e6b72 into webcompat:master Feb 10, 2021
@emilio emilio deleted the patch-1 branch February 10, 2021 03:56
@emilio
Copy link
Contributor Author

emilio commented Feb 10, 2021

ah, didn't notice the focus state was in the textarea.

Should be fixable by moving the outline to .progress-textarea with something like .progress-textarea:focus-within

@karlcow
Copy link
Member

karlcow commented Feb 10, 2021

ok deployed :) v39.0.1...v40.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Textarea progress bar hides text when typing
2 participants