Fix #2015 - Update topsites.py for IAM user credential #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MDTsai yes I can help. Do you need to get it done by today or by monday? |
|
@karlcow by end of January, old credential fail day, thanks ! |
|
(drive by comment, just to see why tests failed): |
Use HTTP GET and different signature then use root credential Fix unittest cases
|
Just fix the PEP8 fail |
karlcow
requested changes
Jan 18, 2018
There was a problem hiding this comment.
@MDTsai Awesome work as usual. ❤️ Thanks.
All the comments and requests for changes are syntactic.
- So I would replace
\nby string structure (though to be tested, specifically for the signing process.) - The code needs to be merged with the latest unit tests structure introduced in Fixes #1986 - Start migration to Intern 4 #1987 But this is smooth I have done it locally. :)
- Remove
import base64in the topsites.py - There are a couple of long lines which needs to be reformatted and/or have
# noqaor# nopep8keywords
| query=canonical_query, | ||
| headers=canonical_headers, | ||
| signed_headers=ATS_SIGNED_HEADERS, | ||
| payload_hash=payload_hash) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| return sign_key | ||
|
|
||
|
|
||
| def get_sha256_hex(data): |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| return urlencode(query_params) | ||
|
|
||
|
|
||
| def gen_sign(data): | ||
| def get_sign_key(key, datestamp, region_name, service_name): | ||
| """AWS sign key from key, datestamp, region and service""" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
No worries @MDTsai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use HTTP GET and different signature then use root credential. @karlcow could you help to review this?