Fixes #1475 - removed side effect when button is active #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
approved these changes
Apr 10, 2017
There was a problem hiding this comment.
Great! This solves the bug, but it's still sort of impossible to visually know when the "remove preview" button has focus (but it does work via the keyboard).
Given that the rest of the site isn't 100% keyboard accessible, let's land this and consider what we can do to improve kb a11y in the future.
miketaylr
added
status: add to changelog
and removed
in progress
status: add to changelog
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I havd followed your idea @miketaylr
r? @miketaylr