Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1063. Un-break image uploads for issue comments. #1067

Merged
merged 4 commits into from
May 28, 2016
Merged

Fixes #1063. Un-break image uploads for issue comments. #1067

merged 4 commits into from
May 28, 2016

Conversation

miketaylr
Copy link
Member

miketaylr
miketaylr reviewed May 26, 2016
View reviewed changes
webcompat/templates/issue/issue-comment-submit.html
</div>
<img class="wc-Upload-Loader wc-Issue-Loader js-Upload-Loader"
src="/img/upload-loader.svg" alt="Uploading image">
</label>

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@miketaylr
Copy link
Member Author

Any other feedback?

@karlcow
Copy link
Member

karlcow commented May 28, 2016

ok. excellent. Let's move on. Thanks for filling the bug on labels. r+ @miketaylr

@karlcow karlcow merged commit 9156c03 into master May 28, 2016
@miketaylr
Copy link
Member Author

Thanks for review Karl!

@miketaylr miketaylr deleted the issues/1063/1 branch May 31, 2016 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketaylr @karlcow @magsout