Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] Tag certain bugs as NSFW and hide images by default? #1001

Closed
miketaylr opened this issue Apr 7, 2016 · 11 comments
Closed

Comments

@miketaylr
Copy link
Member

Often we get reports related to NSFW websites. They can sometimes contain screenshots that are adult-oriented. I wonder if we could add a status-nsfw (or similar, status is probably the wrong prefix), and it would overlay an opaque graphic over any embedded images. You could then click the image to display it, but they would be hidden by default.

(or maybe we have a settings panel somewhere where you opt-in to always see, dunno)

Useful if you're debugging websites and have children around, or are in a public space.

One example is webcompat/web-bugs#2428.

Low priority, but it might be a nice feature to add.

@hallvors
Copy link
Contributor

hallvors commented May 7, 2016

👍 :)

I don't think this label needs a prefix - it can be simply "nsfw" IMO. Possibly "note-nsfw" but I don't think we will have a group of such labels.

This can be added in a very simple way - so simple we could make it a good-first-patch I think:

  1. Add CSS to censor images by default inside body.wc-js-nsfw (or something like that) (where "censor" can be opacity:0.02)
  2. Add CSS to show image anyway if it has a "showme" class
  3. Add JS to add the wc-js-nsfw classname to BODY if the issue we're loading has a nsfw tag
  4. Add JS to add the "showme" class to IMG if it's clicked.

We probably should insert an explanation somewhere saying why the images are hidden.

@miketaylr
Copy link
Member Author

Buzzfeed has an implementation of this: https://www.buzzfeed.com/katienotopoulos/play-23-rounds-of-the-deadliest-game-ever?utm_term=.stpjYylBX#.ttvG7j5Ml

(There's a site bug in Firefox, so open this in Chrome to see it in its full glory.)

@miketaylr
Copy link
Member Author

There's a site bug in Firefox

https://bugzilla.mozilla.org/show_bug.cgi?id=1275069

@miketaylr
Copy link
Member Author

webcompat/web-bugs#2700 is a good example of where this would be useful (hint: it has a nsfw screenshot in the bug report).

@miketaylr miketaylr self-assigned this Jun 6, 2016
miketaylr pushed a commit that referenced this issue Jun 6, 2016
miketaylr pushed a commit that referenced this issue Jun 6, 2016
@karlcow
Copy link
Member

karlcow commented Jun 6, 2016

@miketaylr agreed. The choice of colors on this website is disturbing :p

@miketaylr
Copy link
Member Author

hehe

@miketaylr
Copy link
Member Author

So this is like 90% done, but I'm struggling with how to nicely indicate "click to reveal" (because I suck at UI).

@miketaylr
Copy link
Member Author

Let's start with this, then someone with actual skills can improve it:

screen shot 2016-06-10 at 9 09 30 am

@hallvors
Copy link
Contributor

Seems superb to me :)

@miketaylr
Copy link
Member Author

Cool, thanks! Just need to write some tests now.

@karlcow
Copy link
Member

karlcow commented Jun 10, 2016

The way the messaging is done on the site The Big Picture is not bad.
For example: http://archive.boston.com/bigpicture/2008/11/congos_crisis_worsens.html

capture d ecran 2016-06-10 a 20 26 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants