needscontact needs to call the right API route.

[karlcow]

This is blocking #434

The current call to needscontact is not carried on to the API call.

For example needsdiagnosis is working well, but needscontact is failing and being redirected to all.

The call to the API was:
https://webcompat.com/api/issues?page=1&per_page=50&state=open&stage=all&sort=created&direction=desc
An API call is made to all, while when requesting sitewait for example the API call is made to https://webcompat.com/api/issues/category/sitewait?page=1&per_page=50&state=open&stage=sitewait&sort=created&direction=desc

btw maybe an additional issue. In https://webcompat.com/api/issues/category/sitewait?page=1&per_page=50&state=open&stage=sitewait&sort=created&direction=desc

• /api/issues/category/sitewait
• stage=sitewait

seems to be redundant.

[miketaylr]

Unrelated (maybe?) bug: If you visit https://webcompat.com/api/issues?page=1&per_page=50&state=open&stage=all&sort=created&direction=desc directly in the browser it's... surprising. 💩 👈

[karlcow]

@miketaylr it's a JSON file. What did you notice was wrong?

[miketaylr]

The bug is in toggleFilter of issue-list.js. Right now that will only do what we expect it to if there's a corresponding filter button with [data-filter=needscontact], which I guess is kind of not great, but that means #434 will fix this.

[miketaylr]

@miketaylr it's a JSON file. What did you notice was wrong?

Oh, nevermind. >_< Not fully awake I guess.

[miketaylr]

As for the issue about the redundancy, yeah that's a good point. Right now we just pass along all params to GitHub (and they don't seem to mind), but we could filter out our own at the API level.

[miketaylr]

This will get fixed by #685. If somebody wants to refactor issue-list.js so it doesn't rely on certain DOM elements existing to succeed - that would be a cool contribution. Probably not a huge priority though. 💐

[miketaylr]

I'm gonna close this as a dupe of #434.