Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Avatar Issue Page #483

Closed
andrewmcgivery opened this issue Dec 13, 2014 · 5 comments
Closed

Duplicate Avatar Issue Page #483

andrewmcgivery opened this issue Dec 13, 2014 · 5 comments
Assignees
Milestone

Comments

@andrewmcgivery
Copy link
Contributor

So, if 1 person posts twice on an issue, it is causing a warning because of duplicated alt tags on the avatars.

That being said, it is technique a decorative image so we should probably give it an empty alt text anyways. This should fix the error and actually make the page better for screen reader issues anyways.

<img src="https://avatars.githubusercontent.com/u/67283?v=3" alt="avatar miketaylr">

to

<img src="https://avatars.githubusercontent.com/u/67283?v=3" alt="">
@magsout
Copy link
Member

magsout commented Dec 13, 2014

So, if 1 person posts twice on an issue, it is causing a warning because of duplicated alt tags on the avatars.

@andrewmcgivery you use a software or addong to see that?

it's not a bad practice to have a non-text element without a text alternative?

@andrewmcgivery
Copy link
Contributor Author

I use WAVE addon by WebAIM. :) I also work at an educational institution in Ontario, Canada where we are under strict laws regarding accessibility. I am immersed in this stuff almost daily. :)

It's actually GOOD practice to have "decorative" images have an empty alt. A screen reader will simply ignore that image. :)

See: http://www.w3.org/TR/WCAG20-TECHS/H67.html and http://davidwalsh.name/accessibility-tip-empty-alt-attributes

@magsout
Copy link
Member

magsout commented Dec 13, 2014

Good to know @andrewmcgivery thanks

@miketaylr miketaylr added this to the Accessibility milestone Dec 17, 2014
@miketaylr
Copy link
Member

Cool, this makes sense. Also I had no idea. 🌈 ⭐

@andrewmcgivery
Copy link
Contributor Author

It's actually something that isn't as "mainstream" knowledge as it should be. Glad my knowledge could be of use though. :)

miketaylr pushed a commit that referenced this issue Dec 18, 2014
Issue #483 - Use an empty alt for decorative avatar image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants