Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow A/B testing settings to be set via environment variable #2944

Closed
miketaylr opened this issue Oct 4, 2019 · 1 comment
Closed

Allow A/B testing settings to be set via environment variable #2944

miketaylr opened this issue Oct 4, 2019 · 1 comment
Assignees

Comments

@miketaylr
Copy link
Member

This way we wouldn't need to deploy every time we want to tweak the branches, we would just restart uwsgi.

cc @karlcow @johngian

@karlcow
Copy link
Member

karlcow commented Oct 4, 2019

so the goal here is to have to avoid to PR and redeploy the codebase for something which is essentially a configuration choice.

# AB testing config
AB_EXPERIMENTS = {
'exp': {
'variations': {
'form-v1': (0, 100),
'form-v2': (100, 100)
},
'max-age': None
}
}

So we could have an environment variable, which can be read when we restart uwsgi.

@miketaylr miketaylr self-assigned this Oct 7, 2019
miketaylr pushed a commit that referenced this issue Oct 7, 2019
miketaylr pushed a commit that referenced this issue Oct 8, 2019
miketaylr pushed a commit that referenced this issue Oct 8, 2019
miketaylr pushed a commit that referenced this issue Oct 8, 2019
karlcow pushed a commit that referenced this issue Oct 10, 2019
And add tests

Issue #2944 - Address review feedback.

Co-Authored-By: Karl Dubost <[email protected]>

Issue #2944 - Fall back to defaults if there is a problem with AB config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants