Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor bugs in New Issues redesign #1235

Closed
miketaylr opened this issue Dec 10, 2016 · 3 comments
Closed

Two minor bugs in New Issues redesign #1235

miketaylr opened this issue Dec 10, 2016 · 3 comments

Comments

@miketaylr
Copy link
Member

STR:

  1. pull latest master and start server
  2. go to any random issue page

expected: issue page loads
actual: oops blank page and this error in the console:

ReferenceError: stateClass is not defined[Learn More]  lodash.custom.min.js%20line%2085%20%3E%20Function:1:61
	anonymous/< http://localhost:5000/js/vendor/lodash.custom.min.js%20line%2085%20%3E%20Function:1:61
	issues.StateButtonView<.render http://localhost:5000/js/lib/issues.js:316:19
	issues.StateButtonView<.initialize/< http://localhost:5000/js/lib/issues.js:301:7
	r http://localhost:5000/js/vendor/lodash.custom.min.js:26:149
	f http://localhost:5000/js/vendor/backbone-min.js:1:2280
	e.Events.trigger http://localhost:5000/js/vendor/backbone-min.js:1:1452
	.set http://localhost:5000/js/vendor/backbone-min.js:1:3904
	issues.Issue<.parse http://localhost:5000/js/lib/models/issue.js:71:5
	.fetch/t.success http://localhost:5000/js/vendor/backbone-min.js:1:4951
	m.Callbacks/j http://localhost:5000/js/vendor/jquery-1.11.2.min.js:2:27290
	m.Callbacks/k.fireWith http://localhost:5000/js/vendor/jquery-1.11.2.min.js:2:28108
	x http://localhost:5000/js/vendor/jquery-1.11.2.min.js:4:22059
	.send/b http://localhost:5000/js/vendor/jquery-1.11.2.min.js:4:25980
@miketaylr
Copy link
Member Author

Oddly enough, this isn't reproducing for me. Possibly we got into a weird state on bad conference wifi, with some GitHub requests not resolving. That said, I'm going to convert this issue to fix two small bugs I discovered while testing.

@miketaylr miketaylr changed the title issues page broken on master Two minor bugs in New Issues redesign Dec 10, 2016
@miketaylr
Copy link
Member Author

Bug 1) Use stateNeedsTriage, not the old stateNew
Bug 2) the label editor has a z-index problem which means you open the file picker, rather than selecting a label that is low enough.

Probably should be 2 different issues, but they're trivial fixes and I'm lazy.

@miketaylr
Copy link
Member Author

r=me :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant