Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3398 -- trying to destroy remote player that doesn't exist #3405

Closed
wants to merge 1 commit into from
Closed

Fix 3398 -- trying to destroy remote player that doesn't exist #3405

wants to merge 1 commit into from

Conversation

lalalune
Copy link
Contributor

Fixes #3398 by null checking remotePlayer

@lalalune lalalune requested a review from alisaad673 July 29, 2022 07:57
@lalalune
Copy link
Contributor Author

If this is happening because of NPCs then maybe we should rethink our algo here

avaer
avaer suggested changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@avaer avaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should never happen. If there is no player in the specs then it should have been removed from this map by the listener.

If it's not being removed by the listener then the listener has a bug.

@lalalune lalalune closed this Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaer avaer avaer requested changes

@alisaad673 alisaad673 Awaiting requested review from alisaad673

Assignees
No one assigned
Labels
ready for qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app gets stuck while we try to switch scene with switched npc('g' key)
2 participants
@lalalune @avaer