Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kalidokit Interface #2768

Open
2 tasks
0reo opened this issue Apr 6, 2022 · 1 comment
Open
2 tasks

Kalidokit Interface #2768

0reo opened this issue Apr 6, 2022 · 1 comment
Assignees

Comments

@0reo
Copy link
Contributor

0reo commented Apr 6, 2022

This is done enough that someone other than me could take it to the finish line.

  • needs to take in inputs from the actual hands, rather than the fakeQuaternion which was being used to test rotation orders (it's an easy switch, the necessary code is already there and commented out)
  • needs major cleanup/optimization, mostly for allocations which are everywhere in the face tracking code path. the cleanup is mostly mechanical as the code should be well behaved and abstracted already, the only problem being dead code and cloning.

Originally posted by @avaer in #1788 (comment)

@0reo 0reo linked a pull request Apr 6, 2022 that will close this issue
@mwmwmw mwmwmw self-assigned this May 9, 2022
@madjin
Copy link
Contributor

madjin commented Jun 22, 2022

Kalidokit is being deprecated for mediapipe as per: https://twitter.com/kalidoface/status/1539643574525972482
https://mediapipe.dev/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants