Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create settings.js file #2657

Open
0reo opened this issue Mar 24, 2022 · 0 comments
Open

Create settings.js file #2657

0reo opened this issue Mar 24, 2022 · 0 comments

Comments

@0reo
Copy link
Contributor

0reo commented Mar 24, 2022

Getting/setting graphics settings should be handled via settings.js file, as suggested in #2512. Reference is below.


  1. Is there ever a need for an app to be setting this? It's an abusable feature (imagine a world that forces quality against your settings) so I don't want to make it easy for apps to override this.

  2. Any such getter usually needs an event system (EventTarget). Otherwise how are you going to update when it's changed?

  3. This should not be owned by metaversefile. These settings should be in settings.js, which exports an EventTarget and abstracts the local storage aspect, rather than littering it across many files in different directories. And the UI should use settings.js so it's one point of control, not different apps with different ideas of what setting are.

Originally posted by @avaer in #2512 (comment)

@0reo 0reo linked a pull request Mar 24, 2022 that will close this issue
@0reo 0reo added this to the Avatar Quality Settings milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant