2550 app detect users gpu settings to define default performance settings #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0reo
force-pushed
the
2550-app-detect-users-gpu-settings-to-define-default-performance-settings
branch
from
1497305 to
5438e9a
Compare
|
We can't enable this (make low a default) until the settings change is performant/done asynchronously. |
|
Blocked on performant/async settings application. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR closes #2550. I've set up defaults for all GFX settings, not just the character details. All GFX settings that go from
LOWtoULTRAwill be set to match the output from detect-gpu. Settings that can beONorOFFwill beONif detected gpu tier is above 1, which isHIGHorULTRA, andOFFif lower than that.If we want any of these GFX defaults to stay fixed, or we want to change the tiers which they are enabled, the adjustment can be done very quickly.
Due to eslinting, I would again suggest turning off white space when reviewing.