Fix: Sil/Sword combat and aim animation problem while walking/running. #2791

gonnavis · 2022-04-08T17:31:58Z

Fix: #2049

Preliminarily fixed this issue. The main changes are these lines.

Basic idea is to not apply sword combo animations to legs when walking.

Now not very awkward, but still has many todos:

Lerp combo and walk/run based on moveFactors.idleWalkFactor.
Check bones by whether shoulder and arm instead of isTop.
Fix when crouch.
Test with silsword.

sword.walk.mp4

avaer · 2022-04-08T20:35:11Z

Looks good! Let's also make sure we are blending correctly for aim mode too (right click mouse).

… combo.

gonnavis · 2022-04-09T09:53:27Z

Crouch:

combo.3.crouch.mp4

Aim:

combo.4.lock.mp4

Hello @avaer , is it ok?

There's still a lot of room for optimization, and with silsword, still looks a little awkward.
But the most obvious ones should be addressed for now, maybe keep fixing in other PRs.

gonnavis · 2022-04-09T16:04:20Z

Noticed that silsword's aim is different from sword's aim logic/codes.
So fixed it's animation problem while walk/run too.

aim.1.mp4

avaer · 2022-04-11T15:21:23Z

Noticed that silsword's aim is different from sword's aim logic/codes.

Yes, the animations are not related at all.

Re: the above, I think the walk/run needs to be blended into the arms when aiming the sword or else it will look wrong/stiff.

gonnavis · 2022-04-11T16:56:58Z

Blended walk/run into arms when aiming.

aim.2.blend.arm_1.mp4

gonnavis · 2022-04-15T06:54:26Z

There is an animation for aiming the sword, but it is much too fast.

Tested that 300ms too slow, so increased to 200ms. 8dfa702

gonnavis · 2022-04-15T07:00:18Z

There is no animation for unaiming the sword.

Also fix: #2573

Generally handled end-action transition, works well for jumping-end, unaiming and attacking-end. 441b049

general.end.action.transition.2.mp4

avaer · 2022-04-15T17:09:26Z

avatars/animationHelpers.js

      };
    } else if (activeAvatar.unuseAnimation && activeAvatar.unuseTime >= 0) {
-      return spec => {
+      return (spec, isLastBone) => {


Hm this isn't a good approach. If something should happen after the last bone then the caller should do that, not the quaternion handler.

This might actually affect performance negatively to pass extra arguments to all bones for all frames.

Ok, @avaer , is this proper? dd0ea6f

avaer · 2022-04-15T17:11:48Z

Hm I don't know if the jump landing is better. It seems to take too long for some cases.

Let's not mix this up with the sword PR. We can do actual landing animations which will look much better.

Also not related to this PR: the spine sword problem is more obvious when you try to attack while running.

This reverts commit 441b049.

gonnavis · 2022-04-15T17:20:44Z

Hm I don't know if the jump landing is better. It seems to take too long for some cases.
Let's not mix this up with the sword PR. We can do actual landing animations which will look much better.

Reverted generally handle end-action transition 441b049 .
I'll trying in subsequent PR.

gonnavis · 2022-04-15T17:36:38Z

the spine sword problem is more obvious when you try to attack while running.

Ok, I think I should add back isCombo bone group which includes arms, Chest and UpperChest.
Otherwise the attack range will reduced a lot by the absent of Chest and UpperChest while walking/running.
What's the name is better, isUpperBody, isAttack, isSword?

And I think we need dedicated attack animations for walking/running/crouching eventually, because these case are way too different from standing attack, can't make good by just blending standing attack.

And maybe we can prevent walking/running/crouching attacking totally, like many other action games do.
If want attack, will auto-stop walking/running/crouching ( temporarily ).
Then this PR is mainly fixing aiming ( or "aggro" state ) animation while walking/running/crouching.

avaer · 2022-04-17T19:32:27Z

animations-baker.js

@@ -35,6 +35,16 @@ const {CharsetEncoder} = require('three/examples/js/libs/mmdparser.js');
    'Crouched Sneaking Left.fbx',
    'Crouched Sneaking Right.fbx',
  ];
+  const trimClip = (clip, startTime, endTime) => {


This is ok to ship, but I think we can fix this in the animation itself in the long term.

Maybe add a comment here/open an issue to trim this animation in Blender.

Ok, added comment first. eb1b8da
I also want to trim this sword animation into three pieces, if the other pr can be merged #2804 .
I'll request artist asset afterwards.

gonnavis · 2022-04-18T17:08:08Z

Resolved conflicts.

gonnavis · 2022-04-19T08:30:00Z

Reverted fixing of unuseAnimation not stop problem, 4dc4625
because it's not very related to this PR and not a serious problem,
should try in another PR afterwards.

avaer · 2022-04-21T02:52:25Z

After testing again:

I still think this PR is far too robotic when walking and attacking. I think overall it is not better than what we had before, it's just a different set of animation problems we are trading for.

At least what we had before was very dynamic even if all of the bones were going crazy.

If we need walk-attack and run-attack custom animations to solve this and make powerful swipes that do not look like a robot (especially in the spine), I think that is a valid plan.

gonnavis · 2022-04-21T08:45:16Z

Got it! I'll contact artist and request resource.

gonnavis · 2022-05-02T14:01:34Z

Only improve silsword with aimAnimation first, reverted changes of useAnimations.
I feel it's better than before, how about only improve sword aimAnimation first?

Before:

aim.sword.before.mp4

After:

aim.sword.after.mp4

gonnavis added 6 commits April 7, 2022 09:22

branch: dev2.

d6f72e1

branch: AnimationsOrigin.

1642d8c

fix bow not work bug. && dev.

0948491

dev

d17c77b

dev. && add pistol & rifle.

a2ee1c2

branch: AnimSwordWalk.

024ab7a

gonnavis added 9 commits April 9, 2022 05:06

lerp leg between sword and walk/run by idleWalkFactor.

d7f6681

lerp full combo animation ( which already processed legs ) when start…

f055d6d

… combo.

use isCombo instead of isTop.

8c6c993

trim combo animation's start a little.

9d869b7

trim combo animation's end to prevent sword cross player's head.

8f576d3

Merge branch 'master' into AnimSwordWalk

c7a3435

add silsword.

de84155

handle crouch sword.

d71e237

clean.

939d70f

gonnavis force-pushed the AnimSwordWalkPr branch from dfd9b22 to 939d70f Compare April 9, 2022 09:50

gonnavis marked this pull request as ready for review April 9, 2022 09:53

gonnavis requested a review from avaer April 9, 2022 09:54

gonnavis added the animation label Apr 9, 2022

fix aimAnimation while walk/run.

93e5d3b

gonnavis changed the title ~~Fix: Sword combat animation while walking/running.~~ Fix: Sword combat and SilSword aim animation while walking/running. Apr 9, 2022

gonnavis changed the title ~~Fix: Sword combat and SilSword aim animation while walking/running.~~ Fix: Sil/Sword combat and aim animation problem while walking/running. Apr 9, 2022

blend walk/run into arms when aiming.

b8db971

gonnavis added 2 commits April 12, 2022 01:25

fix timing problem.

aeefba5

fix unuseAnimation not stop problem.

b6c23c0

avaer reviewed Apr 15, 2022

View reviewed changes

Revert "generally handle end-action transition."

3c365d3

This reverts commit 441b049.

set unuseAnimation = null at outter.

dd0ea6f

gonnavis requested a review from avaer April 17, 2022 09:18

avaer reviewed Apr 17, 2022

View reviewed changes

Merge branch 'master' into AnimSwordWalkPr

276f6b5

gonnavis force-pushed the AnimSwordWalkPr branch from eb1b8da to 276f6b5 Compare April 18, 2022 17:05

gonnavis added 2 commits April 19, 2022 01:06

Rebuild animations.z.

a923e49

add comment.

871866e

gonnavis added 2 commits April 19, 2022 16:17

Merge branch 'master' into AnimSwordWalkPr

1f4de6c

revert fixing of useAnimation not stop problem, may try in another PR.

4dc4625

gonnavis requested a review from avaer April 19, 2022 09:08

gonnavis mentioned this pull request Apr 19, 2022

Add blendList to handle transitions. And add fall/land animations. #2844

Closed

gonnavis marked this pull request as draft April 21, 2022 08:45

gonnavis added 3 commits April 29, 2022 02:10

del trimClip().

f6c2fe4

revert changes of useAnimation.

713446d

improve & clean aimAnimation.

fdd9f79

gonnavis marked this pull request as ready for review May 2, 2022 14:01

gonnavis marked this pull request as draft May 13, 2022 19:24

avaer closed this Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Sil/Sword combat and aim animation problem while walking/running. #2791

Fix: Sil/Sword combat and aim animation problem while walking/running. #2791

gonnavis commented Apr 8, 2022 •

edited

Loading

avaer commented Apr 8, 2022

gonnavis commented Apr 9, 2022 •

edited

Loading

gonnavis commented Apr 9, 2022 •

edited

Loading

avaer commented Apr 11, 2022 •

edited

Loading

gonnavis commented Apr 11, 2022

gonnavis commented Apr 15, 2022

gonnavis commented Apr 15, 2022 •

edited

Loading

avaer Apr 15, 2022

avaer Apr 15, 2022

gonnavis Apr 15, 2022

avaer commented Apr 15, 2022

gonnavis commented Apr 15, 2022 •

edited

Loading

gonnavis commented Apr 15, 2022 •

edited

Loading

avaer Apr 17, 2022

gonnavis Apr 18, 2022 •

edited

Loading

gonnavis commented Apr 18, 2022

gonnavis commented Apr 19, 2022 •

edited

Loading

avaer commented Apr 21, 2022 •

edited

Loading

gonnavis commented Apr 21, 2022

gonnavis commented May 2, 2022 •

edited

Loading

Fix: Sil/Sword combat and aim animation problem while walking/running. #2791

Fix: Sil/Sword combat and aim animation problem while walking/running. #2791

Conversation

gonnavis commented Apr 8, 2022 • edited Loading

avaer commented Apr 8, 2022

gonnavis commented Apr 9, 2022 • edited Loading

gonnavis commented Apr 9, 2022 • edited Loading

avaer commented Apr 11, 2022 • edited Loading

gonnavis commented Apr 11, 2022

gonnavis commented Apr 15, 2022

gonnavis commented Apr 15, 2022 • edited Loading

avaer Apr 15, 2022

Choose a reason for hiding this comment

avaer Apr 15, 2022

Choose a reason for hiding this comment

gonnavis Apr 15, 2022

Choose a reason for hiding this comment

avaer commented Apr 15, 2022

gonnavis commented Apr 15, 2022 • edited Loading

gonnavis commented Apr 15, 2022 • edited Loading

avaer Apr 17, 2022

Choose a reason for hiding this comment

gonnavis Apr 18, 2022 • edited Loading

Choose a reason for hiding this comment

gonnavis commented Apr 18, 2022

gonnavis commented Apr 19, 2022 • edited Loading

avaer commented Apr 21, 2022 • edited Loading

gonnavis commented Apr 21, 2022

gonnavis commented May 2, 2022 • edited Loading

gonnavis commented Apr 8, 2022 •

edited

Loading

gonnavis commented Apr 9, 2022 •

edited

Loading

gonnavis commented Apr 9, 2022 •

edited

Loading

avaer commented Apr 11, 2022 •

edited

Loading

gonnavis commented Apr 15, 2022 •

edited

Loading

gonnavis commented Apr 15, 2022 •

edited

Loading

gonnavis commented Apr 15, 2022 •

edited

Loading

gonnavis Apr 18, 2022 •

edited

Loading

gonnavis commented Apr 19, 2022 •

edited

Loading

avaer commented Apr 21, 2022 •

edited

Loading

gonnavis commented May 2, 2022 •

edited

Loading