-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e test error "project ID request rate exceeded" #7290
Fix e2e test error "project ID request rate exceeded" #7290
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 48bff04 | Previous: adf483f | Ratio |
---|---|---|---|
processingTx |
21845 ops/sec (±8.07% ) |
22201 ops/sec (±6.45% ) |
1.02 |
processingContractDeploy |
38618 ops/sec (±5.59% ) |
38668 ops/sec (±7.43% ) |
1.00 |
processingContractMethodSend |
15645 ops/sec (±9.34% ) |
15754 ops/sec (±8.04% ) |
1.01 |
processingContractMethodCall |
28255 ops/sec (±6.20% ) |
26952 ops/sec (±7.86% ) |
0.95 |
abiEncode |
42626 ops/sec (±7.73% ) |
41355 ops/sec (±6.79% ) |
0.97 |
abiDecode |
31152 ops/sec (±6.27% ) |
29853 ops/sec (±6.08% ) |
0.96 |
sign |
1559 ops/sec (±0.98% ) |
1523 ops/sec (±3.43% ) |
0.98 |
verify |
361 ops/sec (±0.90% ) |
360 ops/sec (±0.74% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7290 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8463 8463
Branches 2339 2339
=======================================
Hits 7993 7993
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR lgtm, requested some minor changes |
Description
Some tests were failing because of the old block was using. I've changed to the latest finalized block.
Link to the GithubAction tests
Tests results with new endpoints
Fixes #7284
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.