Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHANGELOG for PR 7239 #7271

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix CHANGELOG for PR 7239 #7271

merged 2 commits into from
Sep 19, 2024

Conversation

danforbes
Copy link
Contributor

No description provided.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.67 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.26 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 043935c Previous: 5a7e302 Ratio
processingTx 21223 ops/sec (±7.97%) 22309 ops/sec (±7.22%) 1.05
processingContractDeploy 39448 ops/sec (±5.03%) 40363 ops/sec (±6.95%) 1.02
processingContractMethodSend 15409 ops/sec (±9.38%) 16570 ops/sec (±7.02%) 1.08
processingContractMethodCall 28457 ops/sec (±6.17%) 28034 ops/sec (±6.73%) 0.99
abiEncode 43234 ops/sec (±7.54%) 44249 ops/sec (±8.56%) 1.02
abiDecode 28926 ops/sec (±8.52%) 32311 ops/sec (±5.75%) 1.12
sign 1493 ops/sec (±2.93%) 1547 ops/sec (±3.62%) 1.04
verify 367 ops/sec (±0.43%) 367 ops/sec (±0.54%) 1

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (5a7e302) to head (043935c).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7271   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2338     2338           
=======================================
  Hits         7992     7992           
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex
Copy link
Contributor

needs to be changed here as well https://github.com/web3/web3.js/blob/4.x/packages/web3/CHANGELOG.md

@danforbes danforbes merged commit 6f9a485 into 4.x Sep 19, 2024
54 checks passed
@danforbes danforbes deleted the fix/changelog/7239 branch September 19, 2024 16:07
@danforbes danforbes mentioned this pull request Sep 20, 2024
danforbes added a commit that referenced this pull request Sep 20, 2024
danforbes added a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants