From 69555b4bbebfd38fa65aec123504007d55542bee Mon Sep 17 00:00:00 2001 From: Dan Forbes Date: Thu, 5 Sep 2024 15:10:32 -0400 Subject: [PATCH 1/4] fix(onNewProviderDiscovered): callback-parameter Callback for `onNewProviderDiscovered`should have `EIP6963ProvidersMapUpdateEvent` parameter Closes #7241 --- packages/web3/src/web3_eip6963.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web3/src/web3_eip6963.ts b/packages/web3/src/web3_eip6963.ts index 787502a4125..a4fcb3ae028 100644 --- a/packages/web3/src/web3_eip6963.ts +++ b/packages/web3/src/web3_eip6963.ts @@ -82,7 +82,7 @@ export const requestEIP6963Providers = async () => }); -export const onNewProviderDiscovered = (callback: (providerEvent: EIP6963AnnounceProviderEvent) => void) => { +export const onNewProviderDiscovered = (callback: (providerEvent: EIP6963ProvidersMapUpdateEvent) => void) => { if (typeof window === 'undefined') { throw new Error("window object not available, EIP-6963 is intended to be used within a browser"); } From a73884746caa0da22ae7cfa292f55586fbd9902c Mon Sep 17 00:00:00 2001 From: Dan Forbes Date: Thu, 5 Sep 2024 15:14:29 -0400 Subject: [PATCH 2/4] Update Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4f2e5ea09b0..bc14cf92ab5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2697,4 +2697,6 @@ If there are any bugs, improvements, optimizations or any new feature proposal f - Revert `TransactionFactory.registerTransactionType` if there is a version mistatch between `web3-eth` and `web3-eth-accounts` and fix nextjs problem. (#7216) +- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242) + ## [Unreleased] From 4f9eba0069cda0fd74d01e0d9f00ff6e775f4a88 Mon Sep 17 00:00:00 2001 From: Dan Forbes Date: Mon, 9 Sep 2024 10:01:28 -0400 Subject: [PATCH 3/4] Fix Changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6378a55efd6..fbdc1f08e08 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2697,10 +2697,10 @@ If there are any bugs, improvements, optimizations or any new feature proposal f - Revert `TransactionFactory.registerTransactionType` if there is a version mistatch between `web3-eth` and `web3-eth-accounts` and fix nextjs problem. (#7216) -- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242) #### web3 - `Web3.providers` namespace exports `type EIP6963ProviderResponse = Map`. Return type for the static `Web3.requestEIP6963Providers` is now `Promise`. (#7239) +- The callback function provided to the static `Web3.onNewProviderDiscovered` function expects a parameter of type `EIP6963ProvidersMapUpdateEvent` as opposed to `EIP6963AnnounceProviderEvent`. (#7242) ## [Unreleased] From c1776653c8355972fd13ca7683d199445bd5c135 Mon Sep 17 00:00:00 2001 From: Dan Forbes Date: Mon, 9 Sep 2024 10:02:21 -0400 Subject: [PATCH 4/4] Remove Unnecessary Whitespace --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fbdc1f08e08..908ae117acc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2697,7 +2697,6 @@ If there are any bugs, improvements, optimizations or any new feature proposal f - Revert `TransactionFactory.registerTransactionType` if there is a version mistatch between `web3-eth` and `web3-eth-accounts` and fix nextjs problem. (#7216) - #### web3 - `Web3.providers` namespace exports `type EIP6963ProviderResponse = Map`. Return type for the static `Web3.requestEIP6963Providers` is now `Promise`. (#7239)