-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default return format to the context #6947
Add default return format to the context #6947
Conversation
…at-in-global-web3-instance-class
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6947 +/- ##
=======================================
Coverage 91.96% 91.97%
=======================================
Files 215 215
Lines 8226 8273 +47
Branches 2220 2268 +48
=======================================
+ Hits 7565 7609 +44
- Misses 661 664 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 5913c9e | Previous: 6c075db | Ratio |
---|---|---|---|
processingTx |
8774 ops/sec (±4.18% ) |
9301 ops/sec (±4.81% ) |
1.06 |
processingContractDeploy |
37741 ops/sec (±6.91% ) |
39129 ops/sec (±7.62% ) |
1.04 |
processingContractMethodSend |
19060 ops/sec (±4.69% ) |
19443 ops/sec (±5.19% ) |
1.02 |
processingContractMethodCall |
36683 ops/sec (±6.28% ) |
38971 ops/sec (±6.34% ) |
1.06 |
abiEncode |
41143 ops/sec (±6.50% ) |
44252 ops/sec (±6.92% ) |
1.08 |
abiDecode |
27821 ops/sec (±7.91% ) |
30419 ops/sec (±8.89% ) |
1.09 |
sign |
1554 ops/sec (±3.58% ) |
1656 ops/sec (±4.08% ) |
1.07 |
verify |
378 ops/sec (±0.51% ) |
373 ops/sec (±0.78% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
…at-in-global-web3-instance-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(edited)
@avkos precedence will be following:
- local function format ( if defined will be considered first )
- else context format
for all packages
…at-in-global-web3-instance-class
…at-in-global-web3-instance-class
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6281
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.