Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.2 #5740

Merged
merged 7 commits into from
Jan 30, 2023
Merged

1.8.2 #5740

merged 7 commits into from
Jan 30, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jan 10, 2023

Changed

Fixed

Removed

Added

Security

@jdevcs jdevcs added Release 1.x 1.0 related issues labels Jan 10, 2023
@jdevcs jdevcs self-assigned this Jan 10, 2023
@coveralls
Copy link

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 3886282402

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 269 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+2.4%) to 75.028%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 2 64.29%
packages/web3-core-helpers/src/formatters.js 8 84.3%
packages/web3-core-helpers/src/errors.js 29 1.56%
packages/web3-utils/src/soliditySha3.js 34 3.43%
packages/web3-utils/src/index.js 40 40.3%
packages/web3-utils/src/utils.js 45 10.67%
packages/web3-eth-accounts/src/index.js 111 22.94%
Totals Coverage Status
Change from base Build 3886244727: 2.4%
Covered Lines: 3299
Relevant Lines: 4146

💛 - Coveralls

@jdevcs jdevcs marked this pull request as ready for review January 11, 2023 12:32
@jdevcs
Copy link
Contributor Author

jdevcs commented Jan 11, 2023

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@luu-alex
Copy link
Contributor

luu-alex commented Jan 11, 2023

When running synthetix, I got a few errors

edit:

ISSUE RESOLVED ✅

@luu-alex
Copy link
Contributor

Openzeppelin tests are passing ✅

@jdevcs jdevcs mentioned this pull request Jan 16, 2023
@avkos
Copy link
Contributor

avkos commented Jan 19, 2023

synthetix test results

 4435 passing (1h)
  71 pending
  1 failing

  1) Contract: SupplySchedule
       functions and modifiers
         Given inflation amount of 800,000 - mintable supply
           should calculate the mintable supply as 0 within 1st week of inflation start date:
     Error: Time parameter (Wed Mar 06 2019 23:00:00 GMT-0500 (Eastern Standard Time)) is less than now Wed Mar 06 2019 23:11:08 GMT-0500 (Eastern Standard Time). You can only fast forward to times in the future.
      at fastForwardTo (test/utils/index.js:111:10)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/contracts/SupplySchedule.js:205:5)

@openzeppelin/test-helpers finished with errors:

 275 passing (55s)
  3 failing

  1) expectRevert
       expectRevert
         rejects a revert with incorrect expected reason:

      AssertionError: expected 'VM Exception while processing transac…' to equal 'Call to revert'
      + expected - actual

      -VM Exception while processing transaction: revert Call to revert
      +Call to revert
      
      at Context.<anonymous> (test/src/expectRevert.test.js:34:35)

  2) expectRevert
       assertion
         rejects an outOfGas:
     AssertionError: expect.fail()
      at assertFailure (test/helpers/assertFailure.js:9:10)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:123:7)

  3) expectRevert
       outOfGas
         accepts an outOfGas:

      Wrong kind of exception received
      + expected - actual

      -Transaction: 0x30de5aa6fcc2811d6a7407af251c16b423e14efe5219ebfd895a273de802c567 exited with an error (status 0) after consuming all gas.
      -     Please check that the transaction:
      -     - satisfies all conditions set by Solidity `assert` statements.
      -     - has enough gas to execute the full transaction.
      -     - does not trigger an invalid opcode by other means (ex: accessing an array out of bounds).
      +out of gas
      
      at expectException (src/expectRevert.js:20:30)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:153:7)


@luu-alex
Copy link
Contributor

I just checked and the all failing testcases I have mentioned have been reported by me since a year ago. I don't believe anything has changed.

@jdevcs
Copy link
Contributor Author

jdevcs commented Jan 24, 2023

I just checked and the all failing testcases I have mentioned have been reported by me since a year ago. I don't believe anything has changed.

Thanks @luu-alex , @avkos and @Muhammad-Altabba #5760

@jdevcs
Copy link
Contributor Author

jdevcs commented Jan 25, 2023

We will include #5752 in this release if there are any code changes required , discussed in web3 team meeting.

@jdevcs
Copy link
Contributor Author

jdevcs commented Jan 30, 2023

There are no code changes required for fixing #5752 in #5779 , only test code is changed so we will include/merge this PR in next release.

@jdevcs jdevcs changed the title 1.8.2-rc.0 1.8.2 Jan 30, 2023
@jdevcs jdevcs merged commit 632c5d3 into 1.x Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants