Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decodeParameters (web3-eth-abi) should accept readonly AbiInput[] #7136

Closed
Jack-Works opened this issue Jul 3, 2024 · 2 comments
Closed

decodeParameters (web3-eth-abi) should accept readonly AbiInput[] #7136

Jack-Works opened this issue Jul 3, 2024 · 2 comments
Assignees
@jdevcs
Labels
4.x 4.0 related Bug Addressing a bug P1 High severity bugs

Comments

@Jack-Works
Copy link 

decodeParameters((abi as AbiFunctionFragment).outputs, output)

reports the following type error:

Argument of type 'readonly AbiParameter[]' is not assignable to parameter of type 'AbiInput[]'.

I have to write this but this is unnecessary

decodeParameters([...(abi as AbiFunctionFragment).outputs], output)
@Jack-Works
Copy link
Author

Also happens in decodeLog

@SantiagoDevRel
Copy link
Member

Thanks @Jack-Works , the team will take a look at this asap💪

@mconnelly8 mconnelly8 added Bug Addressing a bug 4.x 4.0 related labels Jul 8, 2024
@mconnelly8 mconnelly8 added P0 Critical severity bugs P1 High severity bugs and removed P0 Critical severity bugs labels Sep 16, 2024
@jdevcs jdevcs self-assigned this Sep 26, 2024
@jdevcs jdevcs mentioned this issue Sep 26, 2024
Merged
17 tasks
@jdevcs jdevcs closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdevcs jdevcs

Labels
4.x 4.0 related Bug Addressing a bug P1 High severity bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Jack-Works @SantiagoDevRel @jdevcs @mconnelly8