Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using exports like export * from "./somefile" #5794

Open
Muhammad-Altabba opened this issue Jan 30, 2023 · 2 comments
Open

Stop using exports like export * from "./somefile" #5794

Muhammad-Altabba opened this issue Jan 30, 2023 · 2 comments
Labels
4.x 4.0 related 5.x 5.0 related issues Discussion

Comments

@Muhammad-Altabba
Copy link
Contributor

Discuss and possibly implement the following suggestion:
#5771 (comment)

"... I noticed is that every package has indexed with exports like export * from "./somefile", I think it's a bad practice because:

  • if you are exporting everything from every file, every change is gonna be breaking change - maybe consider exporting only stuff that developers or you actually need
  • if the developer is searching for the source code of some imported class, it's gonna be a nightmare because it could be in any of these files so you can't just ctrl+click to dig through source code

Originally posted by @mpetrunic in #5771 (comment)

@mpetrunic
Copy link
Contributor

@mconnelly8 This is not breaking change really. Any reason why you've pushed this to 5.x?

@mconnelly8
Copy link

@mpetrunic The team discussed this and determined it was low priority and scheduled for v5. I don't remember if this was questionably a breaking change. Maybe @jdevcs or @Muhammad-Altabba might remember that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related 5.x 5.0 related issues Discussion
Projects
None yet
Development

No branches or pull requests

3 participants