Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC-777 and multisig contracts type tests #4631

Closed
1 of 2 tasks
nazarhussain opened this issue Dec 15, 2021 · 0 comments
Closed
1 of 2 tasks

Add ERC-777 and multisig contracts type tests #4631

nazarhussain opened this issue Dec 15, 2021 · 0 comments
Labels
4.x 4.0 related Feature Request

Comments

@nazarhussain
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Feature Request

We currently covered ERC-20 and ERC-721 type tests. It would be nice to add more of these tests to cover ERC-777 and MultiSig contracts.

Use Cases

  • Those contracts are very commonly used, having the types tested for those will provide more stable API for the contracts.

Implementation Ideas

https://github.com/ChainSafe/web3.js/blob/902f6e937913820d137a3e866c4bb9254140016f/packages/web3-eth-contract/test/unit/contract_typing.test.ts#L8

Feature Examples/References

No response

Are you willing to implement this feature?

  • Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x 4.0 related Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nazarhussain @mconnelly8