Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc update for chainId #4576

Closed
jdevcs opened this issue Nov 23, 2021 · 0 comments · Fixed by #4674
Closed

doc update for chainId #4576

jdevcs opened this issue Nov 23, 2021 · 0 comments · Fixed by #4674
Assignees
@luu-alex
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation

Comments

@jdevcs
Copy link
Contributor

jdevcs commented Nov 23, 2021

chainId defaults to eth_chainId rpc call but its not correct in doc here :

chainId - String: (optional) The chain id to use when signing this transaction. Default will use web3.eth.net.getId(). which is net_version

so need doc correction
@jdevcs jdevcs added the 1.x 1.0 related issues label Nov 23, 2021
@jdevcs jdevcs added the Documentation Relates to project wiki or documentation label Jan 4, 2022
@luu-alex luu-alex mentioned this issue Jan 7, 2022
Merged
@luu-alex luu-alex linked a pull request Jan 10, 2022 that will close this issue
correction in documentation for signtransaction accounts #4674
Merged
@jdevcs jdevcs mentioned this issue Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luu-alex luu-alex

Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

correction in documentation for signtransaction accounts web3/web3.js
2 participants
@luu-alex @jdevcs