Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toAscii stops at zero byte #218

Closed
chriseth opened this issue May 25, 2015 · 0 comments
Closed

toAscii stops at zero byte #218

chriseth opened this issue May 25, 2015 · 0 comments
Labels
Bug Addressing a bug

Comments

@chriseth
Copy link
Contributor

The toAscii function in https://github.com/ethereum/web3.js/blob/25d9f5121735b76481b2518fe49ae285b75bac4d/lib/utils/utils.js#L86 stops once it encounters a zero byte.

Since javascript strings do support zero bytes and the current decoding throws away data, is this really justified?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frozeman @chriseth