removing filter, seems to break polling

[frozeman]

After calling MyFilter.stopWatching() i get:

Uncaught TypeError: Cannot read property 'callback' of undefined    web3.js:3689

pointing to:

RequestManager.prototype.poll = function () {
    this.timeout = setTimeout(this.poll.bind(this), c.ETH_POLLING_TIMEOUT);

    if (!this.polls.length) {
        return;
    }

    if (!this.provider) {
        console.error(errors.InvalidProvider());
        return;
    }

    var payload = Jsonrpc.getInstance().toBatchPayload(this.polls.map(function (data) {
        return data.data;
    }));

    var self = this;
    this.provider.sendAsync(payload, function (error, results) {
        // TODO: console log?
        if (error) {
            return;
        }

        if (!utils.isArray(results)) {
            throw errors.InvalidResponse(results);
        }

        results.map(function (result, index) {
            result.callback = self.polls[index].callback; // <- ERROR is here
            return result;
        }).filter(function (result) {
            var valid = Jsonrpc.getInstance().isValidResponse(result);
            if (!valid) {
                result.callback(errors.InvalidResponse(result));
            }
            return valid;
        }).filter(function (result) {
            return utils.isArray(result.result) && result.result.length > 0;
        }).forEach(function (result) {
            result.callback(null, result.result);
        });
    });
};

It seems like the results returned still have the same index, which does fit with the callback index anymore.
A quick fix would be to check if(self.polls[index]), but we probably should better check if the poll is not firing the non-existing filter anymore, as i got 101 errors of the above type.

[debris]

👍 I will fix it.