fix: load first page of uploads list in provider #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than doing this in the headless component, do it in the provider so that hook users also get a page of results
weird timing issues occur when you try to do this in the provider - move it to the hook to get around them
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df04d6f:
|
jchris
approved these changes
Jan 24, 2023
| next: async () => {}, | ||
| reload: async () => {} | ||
| next: async () => { }, | ||
| reload: async () => { } |
There was a problem hiding this comment.
Should we isolate white space changes to a code base wide pr?
I think it's better to have this in the provider so that anyone using this context gets a page of results previously I thought this wouldn't work, but that was just because I wasn't doing a good job with dependency management - now that it's configured to re-run the load any time the space or agent change, it seems to work as expected
|
just a heads up to reviewers that the churn between different solutions here is exactly the kind of thing that a nice test can help clarify and coincidentally I was just saying I want to write some tests before we cut a release - I'm gonna write some nice tests for this tonight or tomorrow |
olizilla
approved these changes
Jan 24, 2023
|
lol, innocent me upthread thinking a test for this would be simple - spent a bunch of time working out how to do this and made some progress, but decided to merge as-is and come back later with tests - mocking the service interaction and dealing with async functions running in the provider is extra spicy testing fun - doable, but will take a bit more work than I'd like to do before getting this in |
This was referenced Jan 25, 2023
This was referenced Feb 2, 2023
travis
added a commit
that referenced
this pull request
Feb 8, 2023
🤖 I have created a release *beep* *boop* --- ## [2.1.0](react-uploads-list-v2.0.1...react-uploads-list-v2.1.0) (2023-02-06) ### Features * "Headless" UI components ([#136](#136)) ([46583e0](46583e0) ### Bug Fixes * load first page of uploads list in provider ([#288](#288)) ([6778d6c](6778d6c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [2.1.0](storacha/w3ui@react-uploads-list-v2.0.1...react-uploads-list-v2.1.0) (2023-02-06) ### Features * "Headless" UI components ([#136](storacha/w3ui#136)) ([b702889](storacha/w3ui@b702889) ### Bug Fixes * load first page of uploads list in provider ([storacha#288](storacha/w3ui#288)) ([8a79ad9](storacha/w3ui@8a79ad9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than doing this in the headless component, do it in the hook so that hook users also get a page of results. originally had this in the provider but that had timing issues and only worked sometimes.