feat(access-api): access-api version endpoint has publicKey property #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he underlying did:key publicKey, even if signer.did() is a did:web
gobengo
commented
Dec 14, 2022
| @@ -42,7 +43,7 @@ export interface Env { | |||
|
|
|||
| export interface RouteContext { | |||
| log: Logging | |||
| signer: Signer | |||
There was a problem hiding this comment.
This Signer didn't resolve to anything before in my tsc setup, so was treated as any
gobengo
changed the title
alanshaw
approved these changes
Dec 15, 2022
gobengo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.2.0](access-api-v4.1.0...access-api-v4.2.0) (2022-12-15) ### Features * **access-api:** access-api version endpoint has publicKey property ([#317](#317)) ([474d561](474d561)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
added a commit
that referenced
this pull request
Apr 11, 2023
…317) ...which is always the underlying did:key publicKey, even if signer.did() is a did:web Motivation * #316 * historically there has been a `did` property, which is (historically) always a `did:key` (so a public key) * now we deal with non-key dids like `did:web`. So the did may not be identical to the public key (you have to resolve a `did:web` to determine its pubkeys) * we should have a property that is explicitly only ever a public key (serialized as a `did:key` string) * e.g. for code like this to rely on: https://github.com/web3-storage/w3protocol/blob/main/packages/access-client/src/cli/utils.js#L40 (which I think will break when version endpoint's `did` property is a `did:web`) Rants * try to avoid calling things 'did' when you mean 'public key'. Or assuming that things called 'did' will always be a `did:key` * we often say 'did' or 'did:key' when we mean 'keypair', which is confusing because: * 1. a 'did' may have zero keypairs * 2. a 'did:key', on its own, has no private key. You can't make a 'signer' from only a `did:key` string.
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.0](access-api-v4.1.0...access-api-v4.2.0) (2022-12-15) ### Features * **access-api:** access-api version endpoint has publicKey property ([#317](#317)) ([83dcb45](83dcb45)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which is always the underlying did:key publicKey, even if signer.did() is a did:web
Motivation
didproperty, which is (historically) always adid:key(so a public key)did:web. So the did may not be identical to the public key (you have to resolve adid:webto determine its pubkeys)did:keystring)didproperty is adid:web)Rants
did:keydid:keystring.