feat: optional space name #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fc87174
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a029fe5.ucan-protocol.pages.dev |
| Branch Preview URL: | https://feat-optional-space-name.ucan-protocol.pages.dev |
alanshaw
pushed a commit
that referenced
this pull request
Nov 23, 2022
🤖 I have created a release *beep* *boop* --- ## [6.1.0](access-v6.0.1...access-v6.1.0) (2022-11-23) ### Features * optional space name ([#202](#202)) ([4b7cf64](4b7cf64)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [6.1.0](access-v6.0.1...access-v6.1.0) (2022-11-23) ### Features * optional space name ([#202](#202)) ([c19c29c](c19c29c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
This gets us on the same page as other web3-storage repos. It makes the development workflow more seamless thanks to `workspace:` deps. It also uses use `publishConfig` to optimize dev workflow: by pointing `main` at the typescript file in development, apps that support autoreloading autoreload when dependencies change - hooray! this gets rid of the `build` step during development and feels very slick. Additional changes: 1. remove svelte stuff from rollup configs as they broke this build 2. be more careful about importing types with `import type` In both of these cases this new config resulted in broken builds without these changes. To upgrade: ``` npm clean npm install -g pnpm pnpm install ``` Once that's done, everything should work as it did before, you'll just use `pnpm` instead of `npm` across the board.
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 29, 2025
This gets us on the same page as other web3-storage repos. It makes the development workflow more seamless thanks to `workspace:` deps. It also uses use `publishConfig` to optimize dev workflow: by pointing `main` at the typescript file in development, apps that support autoreloading autoreload when dependencies change - hooray! this gets rid of the `build` step during development and feels very slick. Additional changes: 1. remove svelte stuff from rollup configs as they broke this build 2. be more careful about importing types with `import type` In both of these cases this new config resulted in broken builds without these changes. To upgrade: ``` npm clean npm install -g pnpm pnpm install ``` Once that's done, everything should work as it did before, you'll just use `pnpm` instead of `npm` across the board.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it have to have a name?