feat!: update @ucanto/interface dependencies
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@ucanto/interface` had breaking changes, but because code in dependant libraries didn't change, release-please didn't cut new releases. by manually specifying that the `@ucanto/interface` dependency must by 8 or above, this should trigger a release-please flow to release `@ucanto/interface@8`-compatible releases of these four libs.
Gozala
approved these changes
May 22, 2023
| @@ -29,7 +29,7 @@ | |||
| "dependencies": { | |||
| "@ipld/dag-ucan": "^3.3.2", | |||
| "@noble/ed25519": "^1.7.3", | |||
| "@ucanto/interface": "workspace:^", | |||
| "@ucanto/interface": "workspace:^8", | |||
There was a problem hiding this comment.
I don't think anything here was affected so not sure we need to force update
There was a problem hiding this comment.
I think you're right - I'm going to just go ahead and release it to make the upgrade a little easier for downstream folks (ie, "update everything to 8" rather than "update almost everything to 8")
Merged
I think that's correct - will follow up with a |
travis
added a commit
that referenced
this pull request
May 22, 2023
Gozala
pushed a commit
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ucanto/interfacehad breaking changes, but because code in dependant libraries didn't change, release-please didn't cut new releases.by manually specifying that the
@ucanto/interfacedependency must by 8 or above, this should trigger a release-please flow to release@ucanto/interface@8-compatible releases of these four libs.