feat: configurable audience handlers #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
reviewed
Mar 13, 2023
gobengo
reviewed
Mar 13, 2023
| @@ -242,3 +254,76 @@ test('test access/claim provider', async () => { | |||
| const result = await claim.execute(client) | |||
| assert.deepEqual(result, []) | |||
| }) | |||
|
|
|||
| test('handle did:mailto audiences', async () => { | |||
There was a problem hiding this comment.
btw it would be nice to have a Schema for did:mailto that matches with did:mailto:${string}:${string} because DID.match({ protocol: 'mailto' }) does not satisfy did:mailto:${string}:${string}
There was a problem hiding this comment.
I agree, but that is probably out of scope for ucanto
gobengo
approved these changes
Mar 13, 2023
Merged
This was referenced Apr 11, 2023
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256