feat: initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
4326122 to
7fec9d1
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
7fec9d1 to
7675777
Compare
olizilla
reviewed
Mar 10, 2023
src/index.js
Outdated
Comment on lines
45
to
54
| function getHasher (multihashCode) { | ||
| switch (multihashCode) { | ||
| case sha256.code: | ||
| return sha256 | ||
| case sha512.code: | ||
| return sha512 | ||
| case murmur3128.code: | ||
| return murmur3128 | ||
| case murmur332.code: | ||
| return murmur332 |
There was a problem hiding this comment.
it's really hard to spot if we get one of these wrong... I kinda love this style, where you convert a list of things to the map init format:
const hashMap = new Map([sha256, sha512, murmer3128, ...].map(hash => [hash.code, hash]))
olizilla
reviewed
Mar 10, 2023
src/index.js
Outdated
Comment on lines
32
to
35
| console.log('hasher', hasher, block.bytes) | ||
| const bytesHash = await hasher.digest(block.bytes) | ||
|
|
||
| console.log('has', bytesHash) |
There was a problem hiding this comment.
Suggested change
| console.log('hasher', hasher, block.bytes) | |
| const bytesHash = await hasher.digest(block.bytes) | |
| console.log('has', bytesHash) | |
| const bytesHash = await hasher.digest(block.bytes) |
vasco-santos
commented
Mar 10, 2023
vasco-santos
commented
Mar 10, 2023
olizilla
reviewed
Mar 10, 2023
olizilla
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
minor, but we could re-use the wording from https://github.com/multiformats/js-multiformats/blob/master/src/block.js#L261
so the same error has the same string.
Co-authored-by: Oli Evans <[email protected]>
vasco-santos
commented
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial implementation to validate
@ipld/carblocks for the supported formats by web3.storage. It verifies if block is encoded with one of the hashers supported, as well as if bytes are not bad for the hash