Web2py filesystem issues #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary field type in PostgreSQL is type "BYTEA" not BLOB.
The filename is being inadvertently encoded which results in each subsequent lookup being unable to locate the appropriate path and results in a web2py_filesystem duplicate primary key error when starting py4web.
mdipierro
reviewed
Aug 13, 2022
| @@ -488,7 +488,8 @@ def try_create_web2py_filesystem(db): | |||
| raise NotImplementedError( | |||
| "DatabaseStoredFile only supported by mysql, potresql, sqlite" | |||
| ) | |||
| sql = "CREATE TABLE IF NOT EXISTS web2py_filesystem (path VARCHAR(255), content BLOB, PRIMARY KEY(path));" | |||
| blobType = "BYTEA" if db._adapter.dbengine == "postgres" else "BLOB" | |||
| sql = "CREATE TABLE IF NOT EXISTS web2py_filesystem (path VARCHAR(255), content %(blobType)s, PRIMARY KEY(path));" % {"blobType": blobType} | |||
There was a problem hiding this comment.
This change is problematic. It will may break apps of current users if the table already exists. Can you explain why it is necessary?
There was a problem hiding this comment.
The "BLOB" field type doesn't exist in PostgreSQL, it's type "BYTEA", so currently it just errors attempting to create the web2py_filesystem table with "BLOB type does not exist" since it's not available in PostgreSQL.
https://www.postgresql.org/docs/current/datatype-binary.html
mdipierro
reviewed
Aug 13, 2022
| @@ -315,7 +315,11 @@ def create_table(self, table, migrate=True, fake_migrate=False, polymodel=None): | |||
| query = "CREATE TABLE %s(\n %s\n)%s" % (table_rname, fields, other) | |||
|
|
|||
| uri = self.adapter.uri | |||
| if uri.startswith("sqlite:///") or uri.startswith("spatialite:///"): | |||
| if isinstance(self, InDBMigrator): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic to resolve #696.