count field in restapi

[vincentchevrier]

Using the py4web documentation example of pydal.restapi.

The following url
http://127.0.0.1:8000/superheroes/api/tag?@limit=1&@count=True
will give the following response

{
  "api_version": "0.1",
  "code": 200,
  "count": 10,
  "items": [
    {
      "id": 1,
      "strength": 100,
      "superhero": 1,
      "superpower": 1
    }
  ],
  "status": "success",
  "timestamp": "2022-07-06T21:09:10.940419"
}

note that the count is incorrect, as it should be 1.
I believe this is because the rows are filtered by limit after applying the query here:

pydal/pydal/restapi.py

Lines 464 to 466 in daa85d4

	rows = db(query).select(
	*tfields, limitby=(offset, limit + offset), orderby=orderby
	)

but count is obtained using only the query which does not apply the limit

pydal/pydal/restapi.py

Line 584 in daa85d4

response["count"] = db(query).count()

Presumably count could be obtained by using the length of rows instead?

[mdipierro]

It is not incorrect. count is not supposed to return the number of items in the current response but the total number number of items matching the query. So you know if you need to query for more or not.