Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global name 'urllib' is not defined in pyDAL==17.11 #658

Closed
ngodinhnhien opened this issue May 6, 2021 · 1 comment
Closed

global name 'urllib' is not defined in pyDAL==17.11 #658

ngodinhnhien opened this issue May 6, 2021 · 1 comment

Comments

@ngodinhnhien
Copy link

if not decode_credentials:
    credential_decoder = lambda cred: cred
else:
    credential_decoder = lambda cred: urllib.unquote(cred)

This should be

if not decode_credentials:
    credential_decoder = lambda cred: cred
else:
    credential_decoder = lambda cred: unquote(cred)

I know this will be fixed in next version, but currently my web2py application is using pyDAL 17.11, upgrade pyDAL to later version will cause my app behaves incorrectly (or crashes).

@mdipierro
Copy link
Contributor

This was fixed long ago. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants