Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RethinkDB Adapter support. #282

Open
v3ss0n opened this issue Aug 29, 2015 · 8 comments
Open

RethinkDB Adapter support. #282

v3ss0n opened this issue Aug 29, 2015 · 8 comments

Comments

@v3ss0n
Copy link

v3ss0n commented Aug 29, 2015

RethinkDB have a powerful query language , a bit similar to webp2y's DAL . Should be easy to add RethinkDB adapter.

Is there anyone working on ? If not i will start working on it.

@gi0baro
Copy link
Member

gi0baro commented Aug 30, 2015

Hi @v3ss0n,
a RethinkDB adapter would be awesome. Unfortunately we had not enough time to start writing it: if you would like to start you're absolutely welcome!

@v3ss0n
Copy link
Author

v3ss0n commented Aug 30, 2015

Should i start looking at NoSQL adapter? or Based on Mongo ?

@mdipierro
Copy link
Contributor

Use Mongo as an example, but extend NoSQLAdapter.

@v3ss0n
Copy link
Author

v3ss0n commented Aug 30, 2015

@mdipierro thanks a lot. i will start working on it soon.

@kmcheung12
Copy link

@gi0baro Do we have criteria on picking what db to be supported? E.g. Cassandra is quite popular these days. Shall we add that support?

@gi0baro
Copy link
Member

gi0baro commented Nov 15, 2015

@kmcheung12 the support specific db engines is just a matter of developers working on them.
Making a new adapter means knowing/learning a lot of specific sql commands in the specific engine dialect, and unfortunately, the main team doesn't have the necessary knowledge or the time to do that.

So, practically speaking, the main deal with adapters is to have skilled developers working on them :)

@kmcheung12
Copy link

@gi0baro Sorry to bring the discussion here which is a bit off from this ticket. Does the features listed here supported by all adapters? Our team have been using a self-made cassandra adapter with limited set of operation. I'm hoping to expand its functionality to benefit broader audience.

@gi0baro
Copy link
Member

gi0baro commented Nov 16, 2015

@kmcheung12 don't worry :)
Regarding the features of the adapters, you can certainly push an incomplete adapter, just remember to add a skip in the tests. Even if the adapter doesn't contains all the features supported in pyDAL, submitting to the other developers is a good chance to have other developers contributing to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants