-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES6 modules] Update module linking procedures to follow latest spec updates #6194
[ES6 modules] Update module linking procedures to follow latest spec updates #6194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already reviewed downstream.
Firefox (nightly)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
Sauce (safari)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
Chrome (unstable)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
Sauce (MicrosoftEdge)Testing web-platform-tests at revision 8596b61 All results1 test ran/html/semantics/scripting-1/the-script-element/module/specifier-error.html
|
…updates This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure and #fetch-the-descendants-of-and-instantiate-a-module-script to match recent spec change: whatwg/html#2595 . Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html Bug: 727299, 594639 Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48 Reviewed-on: https://chromium-review.googlesource.com/528724 Commit-Queue: Kouhei Ueno <[email protected]> Reviewed-by: Kinuko Yasuda <[email protected]> Cr-Commit-Position: refs/heads/master@{#478219} WPT-Export-Revision: a1fd48a745a56045e25c3365a69f3fce0358074f
74b2b18
to
77065b4
Compare
[ES6 modules] Update module linking procedures to follow latest spec updates
This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure
and #fetch-the-descendants-of-and-instantiate-a-module-script to match
recent spec change: whatwg/html#2595 .
Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Bug: 727299, 594639
Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48
Reviewed-on: https://chromium-review.googlesource.com/528724
Commit-Queue: Kouhei Ueno [email protected]
Reviewed-by: Kinuko Yasuda [email protected]
Cr-Commit-Position: refs/heads/master@{#478219}
WPT-Export-Revision: a1fd48a745a56045e25c3365a69f3fce0358074f