Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES6 modules] Update module linking procedures to follow latest spec updates #6194

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 9, 2017

[ES6 modules] Update module linking procedures to follow latest spec updates

This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure
and #fetch-the-descendants-of-and-instantiate-a-module-script to match
recent spec change: whatwg/html#2595 .

Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Bug: 727299, 594639
Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48
Reviewed-on: https://chromium-review.googlesource.com/528724
Commit-Queue: Kouhei Ueno [email protected]
Reviewed-by: Kinuko Yasuda [email protected]
Cr-Commit-Position: refs/heads/master@{#478219}
WPT-Export-Revision: a1fd48a745a56045e25c3365a69f3fce0358074f

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@ghost
Copy link

ghost commented Jun 9, 2017

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 8596b61
Using browser at version BuildID 20170608100220; SourceStamp 7efda263a842e60cd0cc00b3c4a7058c65590702
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Subtest Results Messages
OK
Test that invalid module specifier leads to TypeError on window. FAIL assert_equals: expected 1 but got 0

@ghost
Copy link

ghost commented Jun 9, 2017

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 8596b61
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Subtest Results Messages
OK
Test that invalid module specifier leads to TypeError on window. FAIL assert_equals: expected 1 but got 0

@ghost
Copy link

ghost commented Jun 9, 2017

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 8596b61
Using browser at version 60.0.3112.20 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Subtest Results Messages
OK
Test that invalid module specifier leads to TypeError on window. FAIL assert_equals: expected 1 but got 0

@ghost
Copy link

ghost commented Jun 9, 2017

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 8596b61
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Subtest Results Messages
OK
Test that invalid module specifier leads to TypeError on window. FAIL assert_equals: expected 1 but got 0

…updates

This CL updates Blink's impl of #internal-module-script-graph-fetching-procedure
and #fetch-the-descendants-of-and-instantiate-a-module-script to match
recent spec change: whatwg/html#2595 .

Tests: external/wpt/html/semantics/scripting-1/the-script-element/module/specifier-error.html
Bug: 727299, 594639
Change-Id: I022b3b380b408a6d5c75a59d161aea4fe2868f48
Reviewed-on: https://chromium-review.googlesource.com/528724
Commit-Queue: Kouhei Ueno <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Cr-Commit-Position: refs/heads/master@{#478219}
WPT-Export-Revision: a1fd48a745a56045e25c3365a69f3fce0358074f
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-I022b3b380b408a6d5c75a59d161aea4fe2868f48 branch from 74b2b18 to 77065b4 Compare June 9, 2017 07:04
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6b0e959 into master Jun 12, 2017
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-I022b3b380b408a6d5c75a59d161aea4fe2868f48 branch June 12, 2017 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants