[WPT] BFCache: storage events #31080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 4, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
from
ebca549 to
6f3d43d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
from
6f3d43d to
eaf243b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
2 times, most recently
from
ba112d5 to
db034cb
Compare
|
@asutherland, would you able to review this WPT for whatwg/storage#119 (It's also on Chromium Gerrit: https://chromium-review.googlesource.com/c/chromium/src/+/3198458) |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
from
db034cb to
26ecff4
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
4 times, most recently
from
0ed6ccd to
4e08670
Compare
|
@annevk / @asutherland, would you be interested in reviewing this WPT? (We are reviewing it on the Chrome side as well here: https://chromium-review.googlesource.com/c/chromium/src/+/3198458) |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
from
4e08670 to
0067451
Compare
Expectation: When localStorage is modified when a page is in BFCache, storage events should NOT be fired for the page even after the page becomes active. Results: Firefox/Safari: Pass. Chromium: Fail (events are fired, https://crbug.com/1328939). Bug: 1328939, 1107415, whatwg/storage#119 Change-Id: I53c92b2d5f8f4791a43c2c702a441029fdbc7101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198458 Reviewed-by: Marijn Kruisselbrink <[email protected]> Reviewed-by: Rakina Zata Amni <[email protected]> Commit-Queue: Hiroshige Hayashizaki <[email protected]> Cr-Commit-Position: refs/heads/main@{#1009350}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3198458
branch
from
0067451 to
64bf0e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expectation:
When localStorage is modified when a page is in BFCache,
storage events should NOT be fired for the page
even after the page becomes active.
Results:
Firefox/Safari: Pass.
Chromium: Fail (events are fired, https://crbug.com/1328939).
Bug: 1328939, 1107415, whatwg/storage#119
Change-Id: I53c92b2d5f8f4791a43c2c702a441029fdbc7101
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198458
Reviewed-by: Marijn Kruisselbrink <[email protected]>
Reviewed-by: Rakina Zata Amni <[email protected]>
Commit-Queue: Hiroshige Hayashizaki <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1009350}