Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accname] add some tests #26524

Closed
wants to merge 1 commit into from
Closed

[accname] add some tests #26524

wants to merge 1 commit into from

Conversation

xi
Copy link

@xi xi commented Nov 13, 2020

While working on https://github.com/xi/aria-api/ I created some test cases that are not yet covered by wpt. Would be nice if they could be included.

I mostly stuck with the format of existing tests. If desired I can use more expressive titles and descriptions.

@cookiecrook
Copy link
Contributor

looks like this one has been around for a bit. @spectranaut reviews these manual tests now... I'll remove the stale auto-reviewer suggestions soon.

My only feedback is that, since the time that you pushed this PR on 2020, the manual tests moved into a ./manual dir, so it'd be good to move these files there.

Thanks for the PR and sorry it was overlooked for so long!

@spectranaut
Copy link
Contributor

hi @xi, I appreciate the thought and work that went into these tests, unfortunately the manual accname tests have been unmaintained and unused for a while now.

We now have a new way to write automated accname tests specifically, which you can read about here, but we have only just started writing test. If you are still interested in contributing tests, 3 years later, you could help! :)

Without looking too closely, it seems like the tests you wrote here belong with the "name from content" tests, which has a test file and a "to do" to add tests: https://github.com/web-platform-tests/wpt/blob/master/accname/name/comp_name_from_content.html

Closing this PR, but I linked it from the add tests for name from conten issue so who ever works on it can draw inspiration from your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants