From f6036bcc49483a64f2e4d6985b2427b8d43a69fc Mon Sep 17 00:00:00 2001 From: Mason Freed Date: Fri, 17 Feb 2023 11:40:41 -0800 Subject: [PATCH] Rip out all of the beautiful bespoke Popover animation stuff This isn't part of the landed spec [1], and will be replaced by a combination of these five CSSWG issues: - https://github.com/w3c/csswg-drafts/issues/4441 - https://github.com/w3c/csswg-drafts/issues/6429 - https://github.com/w3c/csswg-drafts/issues/8174 - https://github.com/w3c/csswg-drafts/issues/8189 - https://github.com/w3c/csswg-drafts/issues/8389 After this CL, you will no longer be able to animate your popover like this: ``` [popover] { opacity: 0; transition: opacity 0.2s; } [popover]:open { opacity: 1; } ``` Instead you'll need to use CSS animations or (eventually) transitions and you'll have to explicitly declare the `display` and `top-layer` properties: ``` transition: opacity 0.2s, display 0.2s, top-layer 0.2s; ``` [1] https://html.spec.whatwg.org/multipage/popover.html Bug: 1307772,1413556 Change-Id: I4877dd69a06f2624bdb463b065b2e2b66cbf1154 --- .../popover-animated-display-ref.html | 26 -- .../popover-animated-hide-cleanup.html | 98 -------- .../popover-animated-hide-display.html | 57 ----- .../popover-animated-hide-finishes-ref.html | 16 -- .../popover-animated-hide-finishes.html | 56 ----- .../popover-animated-show-display.html | 52 ---- .../popover-animation-corner-cases.html | 230 ------------------ .../popovers/popover-attribute-basic.html | 30 --- html/semantics/popovers/popover-focus.html | 42 +--- 9 files changed, 12 insertions(+), 595 deletions(-) delete mode 100644 html/semantics/popovers/popover-animated-display-ref.html delete mode 100644 html/semantics/popovers/popover-animated-hide-cleanup.html delete mode 100644 html/semantics/popovers/popover-animated-hide-display.html delete mode 100644 html/semantics/popovers/popover-animated-hide-finishes-ref.html delete mode 100644 html/semantics/popovers/popover-animated-hide-finishes.html delete mode 100644 html/semantics/popovers/popover-animated-show-display.html delete mode 100644 html/semantics/popovers/popover-animation-corner-cases.html diff --git a/html/semantics/popovers/popover-animated-display-ref.html b/html/semantics/popovers/popover-animated-display-ref.html deleted file mode 100644 index 477a97c12ccd9dc..000000000000000 --- a/html/semantics/popovers/popover-animated-display-ref.html +++ /dev/null @@ -1,26 +0,0 @@ - - - -
-
This is a popover
- - - diff --git a/html/semantics/popovers/popover-animated-hide-cleanup.html b/html/semantics/popovers/popover-animated-hide-cleanup.html deleted file mode 100644 index 9310acc4ff20980..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-cleanup.html +++ /dev/null @@ -1,98 +0,0 @@ - - - - - - - - - - - - - -I am a dialog - - - - diff --git a/html/semantics/popovers/popover-animated-hide-display.html b/html/semantics/popovers/popover-animated-hide-display.html deleted file mode 100644 index b914d80e69aefa5..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-display.html +++ /dev/null @@ -1,57 +0,0 @@ - - - - - - - -
This is a popover
-
- - - - diff --git a/html/semantics/popovers/popover-animated-hide-finishes-ref.html b/html/semantics/popovers/popover-animated-hide-finishes-ref.html deleted file mode 100644 index d8334f985ed51f3..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-finishes-ref.html +++ /dev/null @@ -1,16 +0,0 @@ - - -
- - diff --git a/html/semantics/popovers/popover-animated-hide-finishes.html b/html/semantics/popovers/popover-animated-hide-finishes.html deleted file mode 100644 index 1af583b5a8315d7..000000000000000 --- a/html/semantics/popovers/popover-animated-hide-finishes.html +++ /dev/null @@ -1,56 +0,0 @@ - - - - - - - -
This is a popover
-
- - - - diff --git a/html/semantics/popovers/popover-animated-show-display.html b/html/semantics/popovers/popover-animated-show-display.html deleted file mode 100644 index 6857103a759b2c2..000000000000000 --- a/html/semantics/popovers/popover-animated-show-display.html +++ /dev/null @@ -1,52 +0,0 @@ - - - - - - - -
This is a popover
-
- - - - diff --git a/html/semantics/popovers/popover-animation-corner-cases.html b/html/semantics/popovers/popover-animation-corner-cases.html deleted file mode 100644 index f41f7a68df9058d..000000000000000 --- a/html/semantics/popovers/popover-animation-corner-cases.html +++ /dev/null @@ -1,230 +0,0 @@ - - - - - - - - - - - - - diff --git a/html/semantics/popovers/popover-attribute-basic.html b/html/semantics/popovers/popover-attribute-basic.html index bc32c357d3a5503..7a106c1407785eb 100644 --- a/html/semantics/popovers/popover-attribute-basic.html +++ b/html/semantics/popovers/popover-attribute-basic.html @@ -32,16 +32,8 @@ Dialog without popover attribute -
Animated popover