Skip to content

Commit

Permalink
Change expectation for invalid/missing shadowRootMode IDL to null
Browse files Browse the repository at this point in the history
Per the spec discussion:

whatwg/html#5465 (comment)

this changes the expectation for the tests to be:

document.createElement("template").shadowRootMode === ""

rather than === null.

Note that this CL does not change Chromium's behavior, and as such
I cannot check if there are other tests that implicitly also
do a similar check. More tests might need to change once I (or
someone) implements this new behavior in a browser.

Bug: 1379513
Change-Id: I0ea1371d612d524fdecc287f3f1790d601c64982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4954120
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: Joey Arhar <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1213658}
  • Loading branch information
mfreed7 authored and chromium-wpt-export-bot committed Oct 23, 2023
1 parent 1d0a6df commit c843715
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions shadow-dom/declarative/declarative-shadow-dom-basic.html
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
t.setAttribute('shadowrootmode','OpEn');
assert_equals(t.shadowRootMode,'open','Case insensitive');
t.setAttribute('shadowrootmode','INVALID');
assert_equals(t.shadowRootMode,null,'Invalid values map to null');
assert_equals(t.shadowRootMode,'','Invalid values map to empty string');
t.removeAttribute('shadowrootmode');
assert_equals(t.shadowRootMode,null,'No shadowrootmode attribute maps to null');
assert_equals(t.shadowRootMode,'','No shadowrootmode attribute maps to empty string');
}, 'Shadowrootmode reflection');

test(() => {
Expand Down

0 comments on commit c843715

Please sign in to comment.