From df0ef55686342fb0d45c7883b44f99b34b43788f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Tue, 15 Jan 2019 10:49:04 +0100 Subject: [PATCH 1/3] Expand on "When to use the RFC process" Addresses https://github.com/web-platform-tests/rfcs/issues/1#issuecomment-454103641. --- README.md | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 4e99a657..5c581b5c 100644 --- a/README.md +++ b/README.md @@ -5,14 +5,12 @@ Most changes in web-platform-tests can be made directly in pull requests following the usual review process. -The RFC (request for comments) process is used to request wider review for -substantial changes, which might impact other stakeholders or users of -web-platform-tests. +This RFC (request for comments) process is used to request wider review. ## When to use the RFC process -A few examples where the process is -likely to be useful: +Use this process for substantial changes which might impact other stakeholders +or users of web-platform-tests. Examples of where it is likely to be useful: - Changes in [resources/](https://github.com/web-platform-tests/wpt/tree/master/resources) which would affect many test authors, such as extending testharness.js. @@ -22,6 +20,13 @@ likely to be useful: - Adding a new third-party code or service dependency. - Changing review workflows or policies. +Cases where the RFC process need *not* be used: + + - Introducing a new top-level directory for a new specification. + - Minor changes in behavior in where all call sites are known and accounted + for. + - Behavior-preserving refactoring with a low risk of regressions. + As a rule of thumb, please use the RFC process when it would be useful and err on the side of skipping it if in doubt! From 56fc69c820798cb419292f43aab9da61565314ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Wed, 16 Jan 2019 14:52:48 +0100 Subject: [PATCH 2/3] Tweak "When to use the RFC process" more --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5c581b5c..a1a49ec6 100644 --- a/README.md +++ b/README.md @@ -9,7 +9,7 @@ This RFC (request for comments) process is used to request wider review. ## When to use the RFC process -Use this process for substantial changes which might impact other stakeholders +Use this process for substantial changes which would impact other stakeholders or users of web-platform-tests. Examples of where it is likely to be useful: - Changes in [resources/](https://github.com/web-platform-tests/wpt/tree/master/resources) @@ -27,8 +27,8 @@ Cases where the RFC process need *not* be used: for. - Behavior-preserving refactoring with a low risk of regressions. -As a rule of thumb, please use the RFC process when it would be useful and err -on the side of skipping it if in doubt! +Feel free to err on the side of skipping the process when it does not seem +valuable. If others disagree they may request that you send an RFC. ## The RFC process From 1a1c7e4917b5de82446bc5a4650820c94eb00c72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Wed, 16 Jan 2019 17:35:13 +0100 Subject: [PATCH 3/3] Remove some words --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index a1a49ec6..59de69e9 100644 --- a/README.md +++ b/README.md @@ -27,9 +27,6 @@ Cases where the RFC process need *not* be used: for. - Behavior-preserving refactoring with a low risk of regressions. -Feel free to err on the side of skipping the process when it does not seem -valuable. If others disagree they may request that you send an RFC. - ## The RFC process - Create a [new issue](https://github.com/web-platform-tests/rfcs/issues/new)