Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Interop-2022 webcompat tests #76

Closed
jgraham opened this issue May 9, 2022 · 5 comments
Closed

Extend Interop-2022 webcompat tests #76

jgraham opened this issue May 9, 2022 · 5 comments
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@jgraham
Copy link
Contributor

jgraham commented May 9, 2022

Proposal is to add https://wpt.fyi/results/css/CSS2/floats/floats-wrap-bfc-with-margin-001.html

That was one of the original bugs on the compat list, but didn't have any coverage at the time. Now it's been decided to align on Blink/WebKit behaviour and Gecko has added a test/fixed the issue, so the test shouldn't be a surprise to anyone, or adversely affect their score.

More details in #9 (comment)

@jgraham jgraham added the test-change-proposal Proposal to add or remove tests for an interop area label May 9, 2022
@foolip
Copy link
Member

foolip commented May 12, 2022

Discussed in #77. Since the test already passes everywhere it's easy to say 👍 to including it. It's a valuable test that came out of this effort.

@nt1m
Copy link
Member

nt1m commented May 16, 2022

@nt1m nt1m closed this as completed May 16, 2022
@foolip
Copy link
Member

foolip commented May 18, 2022

@nt1m looks like you used the interop-2022-compat label while the existing tests used interop-2022-webcompat. I'll fix this.

@nt1m
Copy link
Member

nt1m commented May 18, 2022

oops, thanks for catching this!

@nt1m
Copy link
Member

nt1m commented May 18, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

3 participants