Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max function tests #377

Closed
nt1m opened this issue Jul 8, 2023 · 8 comments
Closed

Add min/max function tests #377

nt1m opened this issue Jul 8, 2023 · 8 comments
Labels
focus area: CSS Math Functions test-change-proposal Proposal to add or remove tests for an interop area

Comments

@nt1m
Copy link
Member

nt1m commented Jul 8, 2023

Test List

https://wpt.fyi/results/css/css-values?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=minmax

Rationale

Some differences in serialization across browsers

@nt1m nt1m added test-change-proposal Proposal to add or remove tests for an interop area focus area: CSS Math Functions labels Jul 8, 2023
@nt1m
Copy link
Member Author

nt1m commented Jul 8, 2023

@emilio @tiaanl Can you help review for Gecko?

@xiaochengh / @nairnandu Can you help review for Chromium?

@emilio
Copy link

emilio commented Jul 8, 2023

+1 from me

@xiaochengh
Copy link

I'm wondering about css/css-values/minmax-percentage-serialize.html, which currently asserts that percentage comparisons are not simplified at parse time.

The spec however seems a bit vague/inconsistent about this.

At one point, it says:

Internal representations of math functions are eagerly simplified to the extent possible

At another point, as a non-normative note, it says:

If a percentage is left at this point, it will usually block simplification of the node, since it needs to be resolved against another value using information not currently available... This includes operations such as "min", since percentages might resolve against a negative basis

However, I find this note not very convincing, because % resolved against a negative value is a very rare case that's currently possible only in the background-position property. So percentage comparisons actually almost never blocks the simplification.

@xiaochengh
Copy link

Other tests LGTM

@nt1m
Copy link
Member Author

nt1m commented Jul 11, 2023

I was actually wondering the same thing looking at css/css-values/minmax-percentage-serialize.html the other day

@nairnandu
Copy link
Contributor

@nt1m closing this one as the change is merged.

@nt1m nt1m reopened this Jul 18, 2023
@nt1m
Copy link
Member Author

nt1m commented Jul 18, 2023

I'm reopening to discuss css/css-values/minmax-percentage-serialize.html

@Loirooriol
Copy link

Would be good to have some test for w3c/csswg-drafts#9631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus area: CSS Math Functions test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

No branches or pull requests

5 participants